OTel-Arrow receiver timeout propagation #34742
Open
+222
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwear
reviewed
Aug 20, 2024
There was a problem hiding this comment.
This needs a go.mod update
Error: ../../receiver/otelarrowreceiver/internal/arrow/arrow.go:44:2: missing go.sum entry for module providing package github.com/open-telemetry/opentelemetry-collector-contrib/internal/grpcutil (imported by github.com/open-telemetry/opentelemetry-collector-contrib/receiver/otelarrowreceiver/internal/arrow);
|
This PR will not pass its automatic checks until #34733 merges. Otherwise I need to re-gen go.mod files which will introduce merge conflicts. It's easier to leave this PR until the other merges. |
|
In fact, when the other PR merges, I will update this one to include an end-to-end test. I'll leave this in draft for now. Reviewers/approvers/maintainers, please focus on #34733. Thanks! |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
I plan to leave this in draft until #34733 merges. |
codeboten
pushed a commit
that referenced
this pull request
Sep 5, 2024
**Description:** Exporter side of open-telemetry/otel-arrow#227. The receiver side is #34742. **Link to tracking Issue:** open-telemetry/otel-arrow#227 **Testing:** Adds a test for the expected metadata propagation. **Documentation:** Since this is expected of gRPC receivers, no docs are changed.
…tor-contrib into jmacd/arrow_recv_timeout
…tor-contrib into jmacd/arrow_recv_timeout
mwear
approved these changes
Sep 6, 2024
mwear
added
the
ready to merge
moh-osman3
approved these changes
Sep 6, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
**Description:** Exporter side of open-telemetry/otel-arrow#227. The receiver side is open-telemetry#34742. **Link to tracking Issue:** open-telemetry/otel-arrow#227 **Testing:** Adds a test for the expected metadata propagation. **Documentation:** Since this is expected of gRPC receivers, no docs are changed.
…tor-contrib into jmacd/arrow_recv_timeout
…etry-collector-contrib into jmacd/arrow_recv_timeout
|
The test failure is unrelated. |
|
This PR is a month old. Please merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Receiver side of open-telemetry/otel-arrow#227. The exporter side is #34733.
Link to tracking Issue: open-telemetry/otel-arrow#227
Testing: A new end-to-end integration test. ✅
Documentation: Since this is expected of gRPC receivers, no docs are changed.