Fix default docker_observer endpoint on Windows #34358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
dmitryax,
jamesmoessis and
rmfitzpatrick
|
Yes, I was waiting the PR number to create one. |
|
also more |
…janotti/opentelemetry-service-contrib into fix-default-discovery-crash-on-windows
…janotti/opentelemetry-service-contrib into fix-default-discovery-crash-on-windows
|
Unrelated windows-unit-test failures, see #34252 |
|
Not sure about this one https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10187830131/job/28182730990?pr=34358#step:6:21 |
|
Also hitting #34297 |
rmfitzpatrick
approved these changes
Aug 1, 2024
|
Similar to the above, but, a different component and symptom https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10207176086/job/28241472190?pr=34358#step:6:21 |
|
/label os:windows |
atoulme
approved these changes
Aug 7, 2024
Just an FYI, I don't believe adding labels via comments works on PRs. (Source) |
crobert-1
added
the
ready to merge
|
@crobert-1 yes, you're right that didn't work here - it did work earlier on an issue 👍🏼 |
|
Another hit on |
dmitryax
approved these changes
Aug 7, 2024
This was referenced Aug 14, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
**Description:**
The default endpoint for the `docker_observer` is incorrect on Windows:
it should be `npipe:////./pipe/docker_engine` on Windows. Without this
change the observer fails on its default configuration on Windows.
Updated `extension/observer/dockerobserver` and `internal/docker`
(including respective tests) to have a per OS default value for endpoint
that allows the observer to work with default config on Windows.
**Link to tracking Issue:** N/A
**Testing:**
Manual tests using the following config:
```yaml
extensions:
docker_observer:
receivers:
receiver_creator:
watch_observers: [docker_observer]
receivers:
nginx:
rule: type == "container" and name matches "nginx" and port == 80
config:
endpoint: '`endpoint`/status'
collection_interval: 10s
exporters:
debug:
verbosity: detailed
service:
extensions: [docker_observer]
pipelines:
logs:
receivers: [receiver_creator]
processors: []
exporters: [debug]
```
**Documentation:**
- [X] Updated readme files
- [X] chloggen (~~pending PR number~~)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The default endpoint for the
docker_observeris incorrect on Windows: it should benpipe:////./pipe/docker_engineon Windows. Without this change the observer fails on its default configuration on Windows.Updated
extension/observer/dockerobserverandinternal/docker(including respective tests) to have a per OS default value for endpoint that allows the observer to work with default config on Windows.Link to tracking Issue: N/A
Testing:
Manual tests using the following config:
Documentation:
pending PR number)