[receiver/gitproviderreceiver] rename metrics to match new conventions #34278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrielp
commented
Jul 28, 2024
crobert-1
reviewed
Jul 30, 2024
receiver/gitproviderreceiver/internal/scraper/githubscraper/github_scraper.go
Show resolved
Hide resolved
crobert-1
approved these changes
Jul 31, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
open-telemetry#34278) **Description:** Updated metrics and attributes to match newest semantic conventions for [VCSs added in the registry](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/attributes-registry/vcs.md). Attribute Changes: - `branch.name` is now `ref.name` - Added a `ref.type` attribute - `pull_request.state` is now `change.state` - `git.vendor.name` is now `vcs.vendor.name` Metric Changes: - `git.repository.count` is now `vcs.repository.count` - `git.repository.contributor.count` is now `vcs.repository.contributor.count` - `git.repository.branch.count` is now `vcs.repository.ref.count` - `git.repository.branch.time` is now `vcs.repository.ref.time` - `git.repository.branch.commit.aheadby.count` is now `vcs.repository.ref.revisions_ahead` - `git.repository.branch.commit.behindby.count` is now `vcs.repository.ref.revisions_behind` - `git.repository.branch.line.addition.count` is now `vcs.repository.ref.lines_added` - `git.repository.branch.line.deletion.count` is now `vcs.repository.ref.lines_deleted` - `git.repository.pull_request.time_open` is now `vcs.change.time_open` - `git.repository.pull_request.time_to_merge` is now `vcs.change.time_to_merge` - `git.repository.pull_request.time_to_approval` is now `vcs.change.time_to_approval` - `git.repository.pull_request.count` is now `vcs.change.count`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updated metrics and attributes to match newest semantic conventions for VCSs added in the registry.
Attribute Changes:
-
branch.nameis nowref.name- Added a
ref.typeattribute-
pull_request.stateis nowchange.state-
git.vendor.nameis nowvcs.vendor.nameMetric Changes:
-
git.repository.countis nowvcs.repository.count-
git.repository.contributor.countis nowvcs.repository.contributor.count-
git.repository.branch.countis nowvcs.repository.ref.count-
git.repository.branch.timeis nowvcs.repository.ref.time-
git.repository.branch.commit.aheadby.countis nowvcs.repository.ref.revisions_ahead-
git.repository.branch.commit.behindby.countis nowvcs.repository.ref.revisions_behind-
git.repository.branch.line.addition.countis nowvcs.repository.ref.lines_added-
git.repository.branch.line.deletion.countis nowvcs.repository.ref.lines_deleted-
git.repository.pull_request.time_openis nowvcs.change.time_open-
git.repository.pull_request.time_to_mergeis nowvcs.change.time_to_merge-
git.repository.pull_request.time_to_approvalis nowvcs.change.time_to_approval-
git.repository.pull_request.countis nowvcs.change.count