Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/opampsupervisor]: Don't fail to start if the OpAMP server is unavailable #34159

Conversation

BinaryFissionGames
Copy link
Contributor

Description:

This PR supercedes #33275

Link to tracking Issue: Fixes #33408, #33799

Testing:

  • Added an e2e test for the behavior
  • Manually tested against BindPlane OP

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on.

cmd/opampsupervisor/e2e_test.go Outdated Show resolved Hide resolved
cmd/opampsupervisor/e2e_test.go Show resolved Hide resolved
@evan-bradley evan-bradley merged commit cc03841 into open-telemetry:main Aug 1, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 1, 2024
@cforce
Copy link

cforce commented Aug 2, 2024

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants