[extension/healthcheckv2] Add partial gRPC service implementation #34028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwear
force-pushed
the
healthcheckv2-grpc-check
branch
from
55ab04a to
ca7d1c9
Compare
This PR introduces the basic structure for the gRPC health check service along with an implementation for the unary `Check` RPC. The streaming `Watch` RPC will be introduced in a followup PR.
mwear
force-pushed
the
healthcheckv2-grpc-check
branch
from
ca7d1c9 to
01755c0
Compare
jpkrohling
approved these changes
Jul 11, 2024
jpkrohling
pushed a commit
that referenced
this pull request
Jul 16, 2024
… service (#34049) **Description:** <Describe what has changed.> The PR is the fifth in a series to decompose #30673 into more manageable pieces for review. This PR builds on #34028 and completes the gRPC service by adding support for the streaming Watch RPC. For reference, the gRPC service is an implementation of [grpc_health_v1 service](https://github.com/grpc/grpc-proto/blob/master/grpc/health/v1/health.proto). **Link to tracking Issue:** #26661 **Testing:** Units / manual **Documentation:** Comments, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The PR is the fourth in a series to decompose #30673 into more manageable pieces for review. This PR introduces the basic structure for the gRPC health check service, which is an implementation of the grpc_health_v1 service. This PR implements the unary
CheckRPC. In order minimize PR size, the streamingWatchRPC will be introduced in a followup.Link to tracking Issue: #26661
Testing: Units / manual
Documentation: Comments, etc.