[cmd/telemetrygen]: Allow float values for rate #33984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
Jul 9, 2024
atoulme
reviewed
Jul 9, 2024
damemi
force-pushed
the
telemetrygen-float-rate
branch
from
4eb7ea1 to
ccb46c1
Compare
|
@atoulme is this all set? |
codeboten
reviewed
Jul 10, 2024
Co-authored-by: Antoine Toulme <antoine@toulme.name>
damemi
force-pushed
the
telemetrygen-float-rate
branch
from
368b942 to
3ee8dd2
Compare
codeboten
approved these changes
Jul 10, 2024
jpkrohling
reviewed
Jul 11, 2024
jpkrohling
reviewed
Jul 15, 2024
…etry-collector-contrib into telemetrygen-float-rate
jpkrohling
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #33982
Switch
--rateflag in telemetrygen to support Float64 valuesLink to tracking Issue: #33982
Testing: Added unit tests for float value cases
Documentation: N/A