Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add host relevant info for container insight receiver #3372

Merged
merged 3 commits into from
Jun 7, 2021
Merged

add host relevant info for container insight receiver #3372

merged 3 commits into from
Jun 7, 2021

Conversation

pxaws
Copy link
Contributor

@pxaws pxaws commented May 11, 2021 •
edited
Loading

Description:
This commit add the host info that are used by container insight receiver. This includes:

  • cpu/mem capacity from gopsutils
  • cluster name and auto scaling group from ec2 tags
  • instance id and type from ec2 metadata
  • ebs volume from ec2 describe volume api and symbolic links on filesystem

Link to tracking Issue:
#2307

Testing:
Unit tests will be added

Documentation:

@pxaws
Copy link
Contributor Author

pxaws commented May 12, 2021

The unit tests are not ready yet. While I am working on them, I hope to get feedback as soon as possible to speed up the process.

@pxaws pxaws marked this pull request as ready for review May 12, 2021 00:25
@pxaws pxaws requested a review from a team May 12, 2021 00:25
pingleig
pingleig reviewed May 12, 2021
View reviewed changes
Copy link
Contributor

@pingleig pingleig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge all the refresh ticker logic.

receiver/awscontainerinsightreceiver/internal/host/ebsvolume.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ebsvolume.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ebsvolume.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ebsvolume.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ebsvolume.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ec2metadata.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ec2metadata.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ec2tags.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ec2tags.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/nodeCapacity.go Outdated Show resolved Hide resolved
@pxaws
Copy link
Contributor Author

pxaws commented May 17, 2021

@alolita @mxiamxia

Aneurysm9
Aneurysm9 suggested changes May 24, 2021
View reviewed changes
receiver/awscontainerinsightreceiver/go.mod Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ebsvolume.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ebsvolume.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ebsvolume.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ebsvolume.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ec2tags.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ec2tags.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ec2tags.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/machineinfo.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/utils.go Outdated Show resolved Hide resolved
pxaws
pxaws commented May 31, 2021
View reviewed changes
Copy link
Contributor Author

@pxaws pxaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactored the code based on previous comments and added the unit tests.

receiver/awscontainerinsightreceiver/go.mod Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ebsvolume.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ebsvolume.go Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ebsvolume.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ec2metadata.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/utils.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ec2tags.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ec2metadata.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ec2metadata.go Outdated Show resolved Hide resolved
receiver/awscontainerinsightreceiver/internal/host/ebsvolume.go Outdated Show resolved Hide resolved
@pxaws pxaws requested a review from Aneurysm9 June 1, 2021 16:15
mxiamxia
mxiamxia approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alolita alolita added the ready to merge Code review completed; ready to merge by maintainers label Jun 4, 2021
@bogdandrutu bogdandrutu merged commit cf1da57 into open-telemetry:main Jun 7, 2021
@pxaws pxaws mentioned this pull request Jul 26, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingleig pingleig pingleig left review comments

@anuraaga anuraaga anuraaga approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@mxiamxia mxiamxia mxiamxia approved these changes

Assignees

@dmitryax dmitryax

Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pxaws @anuraaga @Aneurysm9 @mxiamxia @pingleig @bogdandrutu @alolita @dmitryax