chore: Moves internal/kafka To pkg/kafka

[wicklander-bryant]

Description:
Fixing a bug - As described in the github comment here (#27289 (comment)), users will encounter an error when attempting to use the kafka exporter for a custom collector which requires authentication of any kind. This is because the Authentication field is referencing a struct that is in an internal package, see here.

Link to tracking Issue: #33180

Testing: Seeing as this isn't as much of a functional changes as it is an organizational change the existing tests will cover the changes.

Documentation: N/A - This is a smaller organizational change that is not accompanied by documentation.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: wicklander-bryant / name: Trece Wicklander-Bryant (7896a70)

[strawgate]

I'm not an approver but thanks for taking this on and I don't see anything to comment on in the PR

[wicklander-bryant]

I'm not an approver but thanks for taking this on and I don't see anything to comment on in the PR

No worries at all, thanks for giving it a look through though!

[wicklander-bryant]

I noticed that the gen genotelcontribcol check failed and specified the fix is to run make genotelcontrobcol and commit the changes:

/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/goimports -w  -local github.com/open-telemetry/opentelemetry-collector-contrib ./
Generated code is out of date, please run "make genotelcontribcol" and commit the changes in this PR.

When I run the make genotelcontribcol then run git status there are no changes to commit. The output from running make genotelcontribcol is as follows:

/Users/t.wicklander-bryant/code/personal/opentelemetry-collector-contrib/.tools/builder --skip-compilation --config cmd/otelcontribcol/builder-config.yaml --output-path cmd/otelcontribcol
Flag --output-path has been deprecated, use config distribution::output_path
2024-05-24T00:01:50.152-0700    INFO    internal/command.go:125 OpenTelemetry Collector Builder {"version": "", "date": "unknown"}
2024-05-24T00:01:50.158-0700    INFO    internal/command.go:161 Using config file       {"path": "cmd/otelcontribcol/builder-config.yaml"}
2024-05-24T00:01:50.158-0700    INFO    builder/config.go:132   Using go        {"go-executable": "/usr/local/go/bin/go"}
2024-05-24T00:01:50.166-0700    INFO    builder/main.go:100     Sources created {"path": "cmd/otelcontribcol"}
2024-05-24T00:01:50.671-0700    INFO    builder/main.go:191     Getting go modules
2024-05-24T00:01:50.929-0700    INFO    builder/main.go:107     Generating source codes only, the distribution will not be compiled.
/Library/Developer/CommandLineTools/usr/bin/make --no-print-directory -C cmd/otelcontribcol fmt
Makefile:4: warning: overriding commands for target `lint'
../../Makefile.Common:199: warning: ignoring old commands for target `lint'
gofmt  -w -s ./
/Users/t.wicklander-bryant/code/personal/opentelemetry-collector-contrib/.tools/goimports -w  -local github.com/open-telemetry/opentelemetry-collector-contrib ./

The main branch that this MR targets ended up getting a few new commits and I ended up needing to rebase this branch. Since the target branch was ahead a few commits is that what caused the check failure? It makes sense to me because it's possible that the generated code became out of date. Just want to make sure I don't need to run something else in order to properly generate the code so the check will be happy with me!

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[MovieStoreGuy]

Could I ask you to fix up the conflicts? Once that is done I can get the builds running again :)

[wicklander-bryant]

@MovieStoreGuy That would be greatly appreciated! I've resolved the merged conflicts 👍

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[vincentfree]

@dmitryax It seems this PR is waiting for your approval. Could You take a look? I've tried to fix this same issue a while ago since I was trying to use the struct but failed to do so since the internal/kafka lib contains Authorization which is embedded in the config struct for Kafka.
My PR: #33180 could be closed when this one is accepted.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[CodeMonkeyF5]

Following up on this as it's stuck awaiting rebase. @wicklander-bryant would you be able to do that or provide me access to your fork repo?