Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/haproxy] fix the show stat command #32366

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Apr 13, 2024

Description:
Fix an issue where we called show stats instead of show stat.
This also fixes the situation where no records are present by properly trimming the data.

Link to tracking Issue:
Fixes #32291

Testing:
Added a unit test.

@atoulme atoulme requested a review from MovieStoreGuy as a code owner April 13, 2024 01:46
@atoulme atoulme requested a review from a team April 13, 2024 01:46
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a bug where an integration test would have been really useful, would it be easy to add one?

@atoulme
Copy link
Contributor Author

atoulme commented Apr 19, 2024

This seems like a bug where an integration test would have been really useful, would it be easy to add one?

Filed #32569 to follow up, but no, not so easy, since we deal with sockets, and sockets don't work well with Docker on Mac.

@dmitryax dmitryax merged commit 6f844ed into open-telemetry:main Apr 20, 2024
171 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

haproxy receiver gives error "record on line 21: wrong number of fields" in socket mode
3 participants