prometheusremotewrite: Don't generate target_info unless there are metrics #32318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify prometheusremotewrite.FromMetrics to not generate target_info if there are no metrics, as you can't detect the most recent timestamp. Currently, if there are no metrics, a target_info metric is generated with the Unix epoch for timestamp. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
bugfix/missing-resource-timestamp
branch
from
b38fed9
to
64bee69
Compare
dashpole
approved these changes
Apr 11, 2024
Co-authored-by: David Ashpole <dashpole@google.com>
Aneurysm9
approved these changes
Apr 11, 2024
|
CI failure looks like a flake. |
simonpasquier
approved these changes
Apr 12, 2024
…g-resource-timestamp Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
|
CI flaked again. |
…g-resource-timestamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Modify
prometheusremotewrite.FromMetricsto not generatetarget_infounless there are metrics, as you can't detect a timestamp otherwise. Currently, if there are no metrics, atarget_infometric is generated with the Unix epoch for timestamp.Link to tracking Issue:
See Mimir issue where this was reported.
Testing:
I've added a test case for the bug.
Documentation: