-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/awsxray] Set cloudwatch logs metadata in attributes #32271
Conversation
I've filed #32275 for the failing integration test, it doesn't appear to be related to your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I'd like a code owner or someone with more AWS experience to review as well, I'm not very familiar here 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description:
From the issue:
This change adds the cloudwatch logs metadata to the attributes with the keys
conventions.AttributeAWSLogGroupARNs
andconventions.AttributeAWSLogGroupNames
. Both of these are used by the awsxrayexporter to restore theLogGroupMetadata
.opentelemetry-collector-contrib/exporter/awsxrayexporter/internal/translator/aws.go
Lines 109 to 112 in decc66f
opentelemetry-collector-contrib/exporter/awsxrayexporter/internal/translator/aws.go
Lines 293 to 295 in decc66f
Link to tracking Issue: Fixes #31784
Testing: Added unit tests to validate the translation to attributes.
Documentation: N/A