Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] add string_converter #31790

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

led0nk
Copy link
Contributor

@led0nk led0nk commented Mar 16, 2024

Description:

  • implemented func_string (string_converter)
  • added new unit tests in pkg/ottl/ottlfuncs/func_string_test.go
  • added function to pkg/ottl/ottlfuncs/functions.go
  • updatet README.md at pkg/ottl/ottlfuncs/README.md
  • added changelog

Link to tracking Issue:

Testing:

  • added similar tests as in pkg/ottl/ottlfuncs/func_double_test.go

Documentation:

.chloggen/string-converter.yaml Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/README.md Show resolved Hide resolved
@led0nk led0nk requested a review from TylerHelmuth March 18, 2024 10:30
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case to pkg/ottl/e2e

@led0nk led0nk force-pushed the add-string-converter branch from 72ad0c8 to 008a0cb Compare March 20, 2024 12:23
@led0nk
Copy link
Contributor Author

led0nk commented Mar 20, 2024

updated README - added e2e test cases for string-conversion and updated the function test :)

@led0nk led0nk requested a review from TylerHelmuth March 20, 2024 13:51
@led0nk led0nk closed this Mar 25, 2024
@led0nk led0nk deleted the add-string-converter branch March 25, 2024 21:02
@led0nk led0nk restored the add-string-converter branch March 27, 2024 17:38
@led0nk led0nk reopened this Mar 27, 2024
@led0nk
Copy link
Contributor Author

led0nk commented Mar 27, 2024

accidentally deleted the branch, sorry for that 😅

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 82.11%. Comparing base (80ebb76) to head (008a0cb).
Report is 69 commits behind head on main.

Files Patch % Lines
pkg/ottl/ottlfuncs/func_string.go 47.36% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #31790      +/-   ##
==========================================
+ Coverage   81.94%   82.11%   +0.17%     
==========================================
  Files        1858     1873      +15     
  Lines      172674   174602    +1928     
==========================================
+ Hits       141490   143371    +1881     
- Misses      26892    26929      +37     
- Partials     4292     4302      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Mar 28, 2024
@TylerHelmuth TylerHelmuth merged commit 002ae45 into open-telemetry:main Mar 28, 2024
146 of 147 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 28, 2024
@led0nk led0nk mentioned this pull request Apr 1, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/ottl ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants