-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] add string_converter #31790
[pkg/ottl] add string_converter #31790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test case to pkg/ottl/e2e
72ad0c8
to
008a0cb
Compare
updated README - added e2e test cases for string-conversion and updated the function test :) |
accidentally deleted the branch, sorry for that 😅 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31790 +/- ##
==========================================
+ Coverage 81.94% 82.11% +0.17%
==========================================
Files 1858 1873 +15
Lines 172674 174602 +1928
==========================================
+ Hits 141490 143371 +1881
- Misses 26892 26929 +37
- Partials 4292 4302 +10 ☔ View full report in Codecov by Sentry. |
Description:
pkg/ottl/ottlfuncs/func_string_test.go
pkg/ottl/ottlfuncs/functions.go
pkg/ottl/ottlfuncs/README.md
Link to tracking Issue:
String
converter #27867Testing:
pkg/ottl/ottlfuncs/func_double_test.go
Documentation: