[connector/servicegraphconnector] Gracefully handle half-cleaned metrics #31700
+100
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cleanCache` function cleans up series that haven't been used in 15mins. It does this by: 1. Deleting it from p.keyToMetric (which holds the dimensions for the metric), then 2. Deleting it from all the metric series maps, e.g. p.reqTotal In parallel, the metrics are collected by: 1. Looping through all items in the metric series maps, e.g. p.reqTotal 2. For each, gets the metric's dimensions from p.keyToMetric Because these occur in opposite orders, we can get into a sticky situation where the collector function errors out when getting the metric's dimensions. This PR reverses the order in the cleanup function, hopefully avoiding this situation.
…-up-servicegraph-metric
jpkrohling
reviewed
Mar 14, 2024
jpkrohling
approved these changes
Mar 14, 2024
JaredTan95
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cleanCachefunction cleans up series that haven't been used in 15mins. It does this by:In parallel, the metrics are collected by:
Because these occur in opposite orders, we can get into a sticky situation where the collector function errors out when getting the metric's dimensions.
This PR reverses the order in the cleanup function, hopefully avoiding this situation.
Description:
Link to tracking Issue:
Testing:
Documentation: