[extension/jaegarremotesamplingextension/internal] add goleak tests for jaegerremotesampling extension #31661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add this to your PR description: I'd actually filed a bug for this one specifically 👍 |
crobert-1
reviewed
Mar 8, 2024
Didn't notice about this one. Thanks! |
iblancasa
changed the title
crobert-1
reviewed
Mar 11, 2024
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
iblancasa
force-pushed
the
goleak_jaegerremotesamplingextension
branch
from
1cd4ca3
to
f2b945f
Compare
yurishkuro
approved these changes
Mar 21, 2024
frzifus
approved these changes
Mar 23, 2024
dmitryax
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #30438
Resolves #31157