[receiver/prometheus] Use confighttp for target allocator client #31452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
receiver/prometheus/confighttp-ta
branch
from
b87a72a to
cf8be35
Compare
dashpole
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Lets wait a day or two before merging to give @Aneurysm9 a chance to review. He is more familiar with the target allocator, but I don't see any issues with this.
swiatekm
force-pushed
the
receiver/prometheus/confighttp-ta
branch
2 times, most recently
from
8c74ac0 to
b9653f4
Compare
swiatekm
force-pushed
the
receiver/prometheus/confighttp-ta
branch
from
b9653f4 to
d28c5fc
Compare
TylerHelmuth
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
@dashpole let me know if you'd like to keep waiting or have this merged.
|
lets merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use confighttp for target allocator http client in prometheus receiver.
Link to tracking Issue: #31449
Testing:
Added some simple config tests.
Documentation:
Added a note to the README.