-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/file] Add group_by configuration #31396
[exporter/file] Add group_by configuration #31396
Conversation
9a6c98f
to
e696a38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more nits, and I don't have an answer for the permanent/retryable error question, but otherwise looks good.
Not sure why the checks aren't running. Mind pushing an empty commit to retrigger them? |
I did a main merge because there were some conflicts. The two failing checks seems to be due to an upstream issue: tcort/markdown-link-check#297 |
**Description:** Added the option to write telemetry data into multiple files, where the file path is based on a resource attribute. **Link to tracking Issue:** open-telemetry#24654 **Testing:** Added tests and benchmark for new functionality. **Documentation:** Updated README.md
**Description:** Added the option to write telemetry data into multiple files, where the file path is based on a resource attribute. **Link to tracking Issue:** open-telemetry#24654 **Testing:** Added tests and benchmark for new functionality. **Documentation:** Updated README.md
Description:
Added the option to write telemetry data into multiple files, where the file path is based on a resource attribute.
Link to tracking Issue:
#24654
Testing:
Added tests and benchmark for new functionality.
Documentation:
Updated README.md