[telemetrygen] Fix case where CA is intentionally unset to derive from host CA pool #31249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AlexDCraig
changed the title
AlexDCraig
changed the title
|
Please sign the CLA and I'll be happy to kick off the workflows. |
|
Were you able to identify the PR that caused this regression? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The introduction of TLS configuration broke cases where an individual wants to use the default root CAs provided by the host environment. This adds that functionality back by saying that if a CA file is provided, we will adjust the root CA pool, but not otherwise.
Link to tracking Issue: 31191
Testing: Run telemetrygen against metrics, traces, logs http and grpc endpoints. Test by explicitly providing the root CA cert and not.
Documentation: