Splunkent update conf #31183
Splunkent update conf #31183
Conversation
shalper2
force-pushed
the
splunkent-update-conf
branch
3 times, most recently
from
2e142fd to
54af9a6
Compare
| @@ -8,7 +8,7 @@ jobs. | |||
|
|
|||
| ## Configuration | |||
|
|
|||
| The following settings are required, omitting them will either cause your receiver to fail to compile or result in 4/5xx return codes during scraping. | |||
| The following settings are required, omitting them will either cause your receiver to fail to compile or result in 4/5xx return codes during scraping. These must be set for each Splunk instance type (indexer, search head, or cluster master) from which you wish to pull metrics. At present, only one of each type is accepted, per configured receiver instance. | |||
There was a problem hiding this comment.
Just to clarify here. only one of each type is accepted means that if I had 3 indexers I'd need to have 3 different splunkenterprise receiver entries each with 1 of the indexers included.
Is my reading of that right?
This isn't an issue mostly just a clarification question. TY!
There was a problem hiding this comment.
That's correct! I'll add your example in for clarity.
| loglevel: info | ||
|
|
||
| service: | ||
| extensions: [basicauth/indexer, basicauth/cluster_master] |
There was a problem hiding this comment.
Thank you for documenting this! I can see some getting hung up on the multiple basicauth entries until the concept clicks.
shalper2
force-pushed
the
splunkent-update-conf
branch
from
54af9a6 to
5368c39
Compare
| @@ -28,14 +28,17 @@ func createDefaultConfig() component.Config { | |||
| httpCfg.Headers = map[string]configopaque.String{ | |||
| "Content-Type": "application/x-www-form-urlencoded", | |||
| } | |||
| httpCfg.Timeout = defaultMaxSearchWaitTime | |||
There was a problem hiding this comment.
Was this just not being set before at all? Or was it pulling the default from the httpclient or something?
| return | ||
| } | ||
| ctx = context.WithValue(ctx, endpointType("type"), typeCm) | ||
| // Because we have to utilize network resources for each KPI we should check that each metrics | ||
| // is enabled before proceeding |
There was a problem hiding this comment.
these changes will need to be made on the new indexer search scrapes also I assume? If so mind adding those to the newly merged searches from last PR?
shalper2
force-pushed
the
splunkent-update-conf
branch
6 times, most recently
from
ed9bb40 to
4451226
Compare
| @@ -8,7 +8,7 @@ jobs. | |||
|
|
|||
| ## Configuration | |||
|
|
|||
| The following settings are required, omitting them will either cause your receiver to fail to compile or result in 4/5xx return codes during scraping. | |||
| The following settings are required, omitting them will either cause your receiver to fail to compile or result in 4/5xx return codes during scraping. These must be set for each Splunk instance type (indexer, search head, or cluster master) from which you wish to pull metrics. At present, only one of each type is accepted, per configured receiver instance. This means, for example, that if you have three different "indexer" type instances that you would like to pull metrics from you will need to configure three different `splunkenterprise` receivers for each indexer node you wish to monitor. | |||
There was a problem hiding this comment.
Because I'm a docs dork... Mind putting this in its own paragraph? and/or following a **NOTE:** to REALLY DRIVE HOME this specific thing?
There was a problem hiding this comment.
yea makes sense to me!
shalper2
force-pushed
the
splunkent-update-conf
branch
from
4451226 to
ea6b2a5
Compare
shalper2
force-pushed
the
splunkent-update-conf
branch
from
a9cefbf to
71f9c72
Compare
|
@open-telemetry/collector-contrib-approvers wondering if I could get some eyes on this, thanks! |
|
@atoulme believe i fixed the things |
| The following settings are required, omitting them will either cause your receiver to fail to compile or result in 4/5xx return codes during scraping. | ||
| The following settings are required, omitting them will either cause your receiver to fail to compile or result in 4/5xx return codes during scraping. | ||
|
|
||
| **NOTE:** These must be set for each Splunk instance type (indexer, search head, or cluster master) from which you wish to pull metrics. At present, only one of each type is accepted, per configured receiver instance. This means, for example, that if you have three different "indexer" type instances that you would like to pull metrics from you will need to configure three different `splunkenterprise` receivers for each indexer node you wish to monitor. | ||
|
|
||
| * `basicauth` (from [basicauthextension](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/basicauthextension)): A configured stanza for the basicauthextension. |
There was a problem hiding this comment.
Unrelated to this PR: can we deprecate and remove this option given that we have auth?
There was a problem hiding this comment.
I suppose we can, are we planning on moving away from the basicauth extension entirely? Also a little hesitant at the moment since auth is not super well documented right now.
There was a problem hiding this comment.
I think it's just confusing to have two config options for the same purpose
|
Please run |
shalper2
force-pushed
the
splunkent-update-conf
branch
from
45499f5 to
9ed52bf
Compare
**Description:** Make changes to configuration of the application to allow the user to specify endpoints corresponding to different Splunk node types. Specifically, this update will allow users to define three separate clients: indexer, cluster master, and search head. This change will allow for the addition of metrics corresponding to these different modes of operation within the Splunk enterprise deployment. **Link to tracking Issue:** [30254](open-telemetry#30254) **Testing:** Unit tests were updated to run against new configuration options. **Documentation:** Updated README to reflect the new changes in configuration.
**Description:** Make changes to configuration of the application to allow the user to specify endpoints corresponding to different Splunk node types. Specifically, this update will allow users to define three separate clients: indexer, cluster master, and search head. This change will allow for the addition of metrics corresponding to these different modes of operation within the Splunk enterprise deployment. **Link to tracking Issue:** [30254](open-telemetry#30254) **Testing:** Unit tests were updated to run against new configuration options. **Documentation:** Updated README to reflect the new changes in configuration.
Description: Make changes to configuration of the application to allow the user to specify endpoints corresponding to different Splunk node types. Specifically, this update will allow users to define three separate clients: indexer, cluster master, and search head. This change will allow for the addition of metrics corresponding to these different modes of operation within the Splunk enterprise deployment.
Link to tracking Issue: 30254
Testing: Unit tests were updated to run against new configuration options.
Documentation: Updated README to reflect the new changes in configuration.