Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][mdatagen] Add flag to indicate that component is seeking new code owners #31167

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[chore][mdatagen] Add flag to indicate that component is seeking new code owners #31167

merged 1 commit into from
Feb 19, 2024

Conversation

djaglowski
Copy link
Member

See #31115

@github-actions github-actions bot requested review from atoulme and dmitryax February 9, 2024 17:23
@djaglowski djaglowski marked this pull request as ready for review February 9, 2024 17:38
@djaglowski djaglowski requested a review from a team February 9, 2024 17:38
@djaglowski djaglowski requested a review from crobert-1 February 9, 2024 17:38
crobert-1
crobert-1 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like it, it definitely feels more welcoming to help 👍

cmd/mdatagen/templates/readme.md.tmpl Outdated Show resolved Hide resolved
@djaglowski djaglowski force-pushed the mdatagen-seeking-code-owners branch from 1c40a57 to dc174ef Compare February 9, 2024 18:49
@atoulme
Copy link
Contributor

atoulme commented Feb 11, 2024

Would it be ok to add this to core as well? We're trying to delete mdatagen in contrib with #30495

@djaglowski
Copy link
Member Author

Would it be ok to add this to core as well? We're trying to delete mdatagen in contrib with #30495

Sure, I don't really care where it lives as long as we're generating the correct documentation. Can we have it here in the meantime until the switch is made?

@djaglowski djaglowski mentioned this pull request Feb 12, 2024
Merged
@djaglowski
Copy link
Member Author

Opened open-telemetry/opentelemetry-collector#9552 on core

@djaglowski djaglowski mentioned this pull request Feb 12, 2024
Closed
@djaglowski djaglowski merged commit 91f6cad into open-telemetry:main Feb 19, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 19, 2024
@djaglowski djaglowski deleted the mdatagen-seeking-code-owners branch February 19, 2024 20:36
dmitryax pushed a commit to open-telemetry/opentelemetry-collector that referenced this pull request Feb 22, 2024
@djaglowski
[mdatagen] Add flag to indicate seeking new code owners (#9552)
464003c 
Same implementation as
open-telemetry/opentelemetry-collector-contrib#31167
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
@djaglowski @XinRanZhAWS
[chore][mdatagen] Add flag to indicate that component is seeking new …
0fea916 
…code owners (open-telemetry#31167)

See open-telemetry#31115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@songy23 songy23 songy23 approved these changes

@atoulme atoulme Awaiting requested review from atoulme

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees

@codeboten codeboten

Labels
cmd/mdatagen mdatagen command extension/storage receiver/syslog
Projects
None yet
Milestone
v0.95.0
Development

Successfully merging this pull request may close these issues.
6 participants
@djaglowski @atoulme @songy23 @TylerHelmuth @crobert-1 @codeboten