[chore] Switch to component.MustNewID and component.MustNewIDWithName when passing literal strings
#31125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…")\)' 'component.MustNewID($1)'
…ithName\((".*?")' 'component.
MustNewIDWithName($1'
github-actions
bot
added
connector/servicegraph
exporter/awss3
exporter/azuremonitor
exporter/kinetica
exporter/opensearch
exporter/otelarrow
extension/pprof
extension/storage
internal/aws
internal/sharedcomponent
pkg/stanza
processor/filter
github-actions
bot
added
receiver/skywalking
receiver/solace
receiver/splunkenterprise
receiver/sqlquery
mx-psi
requested review from
dmitryax,
MovieStoreGuy,
djaglowski,
jpkrohling,
Aneurysm9,
dashpole,
TylerHelmuth,
yurishkuro,
atoulme and
jmacd
as code owners
djaglowski
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Runs the following commands:
rg "component.NewID\(\".*?\"\)" -l | xargs sd 'component.NewID\((".*?")\)' 'component.MustNewID($1)'rg "component.NewIDWithName\(\".*?\"" -l | xargs sd 'component.NewIDWithName\((".*?")' 'component. MustNewIDWithName($1'Additionally, makes some manual fixes
Needed for open-telemetry/opentelemetry-collector/pull/9472
Link to tracking Issue: open-telemetry/opentelemetry-collector/issues/9208