Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][exporter/splunkhecexporter] Enable goleak check #30968

Merged
merged 10 commits into from
Mar 8, 2024

Conversation

crobert-1
Copy link
Member

Description:

This enables goleak checks for the splunkhecexporter, to help ensure no goroutines are being leaked. This is a test only change, some Shutdown calls were missing, as well as channel send operations were blocking in tests because there was no one reading from the channel.

Link to tracking Issue:
#30438

Testing:
Existing tests are all passing as well as added goleak check.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 16, 2024
@github-actions github-actions bot removed the Stale label Feb 27, 2024
@crobert-1 crobert-1 removed the exporter/datadog Datadog components label Mar 1, 2024
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Refactor test
- Fix typos
@dmitryax dmitryax merged commit 8fba4db into open-telemetry:main Mar 8, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 8, 2024
DougManton pushed a commit to DougManton/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
…ry#30968)

**Description:** 
This enables `goleak` checks for the splunkhecexporter, to help ensure
no goroutines are being leaked. This is a test only change, some
`Shutdown` calls were missing, as well as channel send operations were
blocking in tests because there was no one reading from the channel.

**Link to tracking Issue:**
open-telemetry#30438

**Testing:** 
Existing tests are all passing as well as added `goleak` check.
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
…ry#30968)

**Description:** 
This enables `goleak` checks for the splunkhecexporter, to help ensure
no goroutines are being leaked. This is a test only change, some
`Shutdown` calls were missing, as well as channel send operations were
blocking in tests because there was no one reading from the channel.

**Link to tracking Issue:**
open-telemetry#30438

**Testing:** 
Existing tests are all passing as well as added `goleak` check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants