[chore][exporter/prometheusexporter] Enable goleak check #30965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-stencel
approved these changes
Feb 2, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
iblancasa
approved these changes
Mar 6, 2024
It would be good if the code owner @Aneurysm9 took a look. |
crobert-1
commented
Mar 25, 2024
dmitryax
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This enables the
goleakpackage for testing the Prometheus exporter. This helps to ensure no goroutines are leaked by this component. This is a test only change, the only updates are making sure all tests close the response body ofGetcalls.Link to tracking Issue:
#30438
Testing:
All tests are passing, including added
goleaktest.