Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][receiver/k8sclusterreceiver] Enable goleak check #30898

Closed
wants to merge 23 commits into from
Closed

[chore][receiver/k8sclusterreceiver] Enable goleak check #30898

wants to merge 23 commits into from

Conversation

crobert-1
Copy link
Member

@crobert-1 crobert-1 commented Jan 30, 2024 •
edited
Loading

Description:

Enable goleak checks to ensure no goroutines are being leaked by this receiver. This is a test only change, as some calls to Shutdown were missing.

Also, as explained in #31047, internal/k8stest was leaking goroutines. This PR now fixes that issue by closing idle HTTP client connections during Shutdown. This is required due to a bug in the k8s/client-go package. The added functionality is a workaround described here.

Link to tracking Issue:
#30438
Resolves #31047

Testing:
All existing tests are passing, as well as added goleak check.

@crobert-1 crobert-1 mentioned this pull request Jan 30, 2024
Open
@crobert-1 crobert-1 removed the receiver/prometheus Prometheus receiver label Jan 31, 2024
@crobert-1
Copy link
Member Author

I still believe the leak is occurring in internal/k8stest since this is the exact same failure as #30842. The current failure is occurring even though all created k8s objects are fully deleted, so I'm wondering if somehow the Create functionality is leaking goroutines that aren't cleaned up by Delete.

Closing for now until I have an opportunity to come back and investigate more.

@crobert-1 crobert-1 closed this Jan 31, 2024
@crobert-1 crobert-1 mentioned this pull request Feb 5, 2024
Closed
@crobert-1 crobert-1 reopened this Mar 25, 2024
@github-actions github-actions bot added cmd/configschema configschema command exporter/datadog Datadog components labels Mar 26, 2024
@crobert-1 crobert-1 added Skip Changelog PRs that do not require a CHANGELOG.md entry and removed exporter/datadog Datadog components processor/k8sattributes k8s Attributes processor receiver/kubeletstats receiver/k8sobjects exporter/alertmanager cmd/configschema configschema command labels Mar 26, 2024
@crobert-1 crobert-1 closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@povilasv povilasv Awaiting requested review from povilasv

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dashpole dashpole Awaiting requested review from dashpole

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146

@hvaghani221 hvaghani221 Awaiting requested review from hvaghani221

@rmfitzpatrick rmfitzpatrick Awaiting requested review from rmfitzpatrick

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@liustanley liustanley Awaiting requested review from liustanley

@mackjmr mackjmr Awaiting requested review from mackjmr

@mx-psi mx-psi Awaiting requested review from mx-psi

@songy23 songy23 Awaiting requested review from songy23

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@mcube8 mcube8 Awaiting requested review from mcube8

@sokoide sokoide Awaiting requested review from sokoide

Assignees
No one assigned
Labels
internal/k8stest processor/k8sattributes k8s Attributes processor receiver/k8scluster receiver/k8sobjects receiver/kubeletstats Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[internal/k8stest] Leaking goroutine when creating and deleting objects
1 participant
@crobert-1