Replace deprecated use of host.ReportFatalError #30693
Conversation
execis
requested review from
jpkrohling,
MovieStoreGuy and
Aneurysm9
as code owners
github-actions
bot
added
receiver/awsfirehose
receiver/datadog
receiver/signalfx
labels
| } | ||
| }() | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
|
|
| @@ -115,7 +115,7 @@ func (r *sfxReceiver) RegisterLogsConsumer(lc consumer.Logs) { | |||
| // Start tells the receiver to start its processing. | |||
| // By convention the consumer of the received data is set when the receiver | |||
| // instance is created. | |||
| func (r *sfxReceiver) Start(_ context.Context, host component.Host) error { | |||
| func (r *sfxReceiver) Start(ctx context.Context, host component.Host) error { | |||
There was a problem hiding this comment.
This change is not necessary - try make lint to see if this passes.
|
Looks like your changelog check didn't pass. To fix this, you can refer to this portion of the CONTRIBUTING.md file:
Or
|
…ed use of host.ReportFatalError
| ddr.params.TelemetrySettings.ReportStatus(component.NewFatalErrorEvent(err)) | ||
| } | ||
| }() | ||
| return nil |
There was a problem hiding this comment.
Please revert whitespace changes
| @@ -47,35 +47,35 @@ func newDataDogReceiver(config *Config, nextConsumer consumer.Traces, params rec | |||
| } | |||
|
|
|||
| func (ddr *datadogReceiver) Start(_ context.Context, host component.Host) error { | |||
There was a problem hiding this comment.
This file should not be part of this PR
| component: signalfxreceiver | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Fixed an issue in the SignalFx receiver where the context parameter was not utilized properly. |
There was a problem hiding this comment.
That's not correct, the changes to signalfxreceiver do not include changing the context parameter.
Given that this change has no impact on user or API changelog, please delete this changelog entry and instead prefix the commit message with [chore] or add the label Skip Changelog to the PR.
| @@ -105,7 +105,7 @@ var _ http.Handler = (*firehoseReceiver)(nil) | |||
|
|
|||
| // Start spins up the receiver's HTTP server and makes the receiver start | |||
| // its processing. | |||
| func (fmr *firehoseReceiver) Start(_ context.Context, host component.Host) error { | |||
| func (fmr *firehoseReceiver) Start(ctx context.Context, host component.Host) error { | |||
There was a problem hiding this comment.
Why is this file changed? I thought the PR was only touching signalfxreceiver.
|
Closing - let's open separate PRs for each component. |
Description:
This update refactors the
Startmethod of thesfxReceiverto remove the deprecatedhost.ReportFatalErrorcall. The code now uses the newsettings.TelemetrySettings.ReportStatusmethod withcomponent.NewFatalErrorEvent(err)to report startup errors.Link to tracking Issue:
#30598
Testing:
The updated code has been tested to handle error scenarios during the startup of the
sfxReceiver, and it now properly reports errors using the new telemetry settings.Documentation:
No changes to external documentation were needed as the change is internal to the
sfxReceiver's implementation and does not affect the receiver's interface or configuration.