Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] move logicmonitor exporter to generated lifecycle tests #30534

Merged

Conversation

Frapschen
Copy link
Contributor

Relates to #27849

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pinging code owners @khyatigandhi6, @avadhut123pisal

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme atoulme force-pushed the logicmonitor_exporter_lifecycle branch from 7db6b89 to 3d12036 Compare January 31, 2024 20:01
@atoulme
Copy link
Contributor

atoulme commented Jan 31, 2024

Pinging code owners @bogdandrutu @khyatigandhi6 @avadhut123pisal

@avadhut123pisal
Copy link
Contributor

LGTM.

@djaglowski djaglowski merged commit 02a3e97 into open-telemetry:main Feb 1, 2024
95 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 1, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
@Frapschen Frapschen deleted the logicmonitor_exporter_lifecycle branch February 2, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants