Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Switch back to upload-artifact v3 #30098

Merged
merged 1 commit into from
Dec 19, 2023
Merged

[chore] Switch back to upload-artifact v3 #30098

merged 1 commit into from
Dec 19, 2023
+9 −9

Conversation

TylerHelmuth
Copy link
Member

Description:
I think v4 is broken (or the way we are using the action is no longer supported in v4). Switching back to v3 for now to fix our CI.

Link to tracking Issue:

I think actions/upload-artifact#471

Testing:

Documentation:

@TylerHelmuth TylerHelmuth requested review from a team and jpkrohling December 19, 2023 17:57
@bogdandrutu
Copy link
Member

@TylerHelmuth can you clarify what breaks? This PR #30091 passed all required CI checks.

@TylerHelmuth
Copy link
Member Author

@bogdandrutu https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/30091/checks didn't run all the checks (I'm not actually sure how you were able to merge).

Renovatebot PRs need closed and reopened to trigger CI once the go mod tidy commit comes through.

songy23
songy23 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bogdandrutu I think #30091 went in effect only after it is merged. Now this step Run actions/upload-artifact@v4 keeps failing in all workflows https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/workflows/build-and-test.yml

@TylerHelmuth
Copy link
Member Author

Renovatebot PRs need closed and reopened to trigger CI once the go mod tidy commit comes through.

NVM this only bumped the actions.

Yes I agree with @songy23

@TylerHelmuth TylerHelmuth merged commit 64853f2 into open-telemetry:main Dec 19, 2023
78 of 83 checks passed
@TylerHelmuth TylerHelmuth deleted the bump-upload-artifacts branch December 19, 2023 18:51
@github-actions github-actions bot added this to the next release milestone Dec 19, 2023
@TylerHelmuth TylerHelmuth mentioned this pull request Dec 19, 2023
Closed
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
@TylerHelmuth @cparkins
[chore] Switch back to upload-artifact v3 (open-telemetry#30098)
c92c46f 
**Description:** 
I think v4 is broken (or the way we are using the action is no longer
supported in v4). Switching back to v3 for now to fix our CI.

**Link to tracking Issue:** <Issue number if applicable>

I think actions/upload-artifact#471

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@songy23 songy23 songy23 approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

Assignees

@bogdandrutu bogdandrutu

Labels
None yet
Projects
None yet
Milestone
v0.92.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TylerHelmuth @bogdandrutu @songy23