Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of the %z strptime format. #29929

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

quentinmit
Copy link
Contributor

Description:

strptime(3) says that %z is "an RFC-822/ISO 8601 standard timezone specification", but the previous code did not allow the string "Z" to signify UTC time, as required by ISO 8601.

Link to tracking Issue: none

Testing:

Added unit tests for both numeric and "Z" time zones.

Documentation: none

`strptime(3)` says that `%z` is "an RFC-822/ISO 8601 standard timezone
specification", but the previous code did not allow the string "Z" to
signify UTC time, as required by ISO 8601.
Copy link
Contributor

github-actions bot commented Jan 2, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 2, 2024
@mx-psi mx-psi removed the Stale label Jan 3, 2024
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog note?

@quentinmit
Copy link
Contributor Author

@mx-psi I think I've done that correctly, PTAL

@mx-psi mx-psi merged commit d95d8c6 into open-telemetry:main Jan 4, 2024
85 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 4, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
**Description:**

`strptime(3)` says that `%z` is "an RFC-822/ISO 8601 standard timezone
specification", but the previous code did not allow the string "Z" to
signify UTC time, as required by ISO 8601.

**Link to tracking Issue:** none

**Testing:**

Added unit tests for both numeric and "Z" time zones.

**Documentation:** none
quentinmit added a commit to GoogleCloudPlatform/opentelemetry-operations-collector that referenced this pull request Jan 18, 2024
- Updates `go-nvml` to enable building with Go 1.21
- Enables the `filelogreceiver`
- Updates `github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal` to pull in open-telemetry/opentelemetry-collector-contrib#29929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants