[mdatagen] add Meter/Tracer func to simplify instrumenting code #29927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 15, 2023 13:20
This allows us to support all component types via a map. This will be used when adding the Meter func in mdatagen to produce consistent scope names for other components than receivers/scrapers. Signed-off-by: Alex Boten <aboten@lightstep.com>
This returns a Meter w/ the scopeName set for each component. Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
requested review from
MovieStoreGuy,
andrzej-stencel,
dashpole,
atoulme,
jmacd,
dmitryax,
fatsheep9146,
jpkrohling and
Aneurysm9
as code owners
codeboten
requested review from
TylerHelmuth,
yurishkuro,
mx-psi,
bogdandrutu,
evan-bradley,
tigrannajaryan,
jsuereth,
arminru,
songy23 and
bryan-aguilar
as code owners
github-actions
bot
added
cmd/mdatagen
github-actions
bot
added
processor/attributes
bogdandrutu
approved these changes
Dec 15, 2023
Comment on lines
21
to
23
| return settings.MeterProvider.Meter("{{ .ScopeName }}") | ||
| } |
There was a problem hiding this comment.
I would start a new telemetry.go.tmpl file since we want to add more things there as well.
There was a problem hiding this comment.
We can do the new file maybe later, but let's add at least for Tracer equivalent.
added 2 commits
December 15, 2023 14:29
Signed-off-by: Alex Boten <aboten@lightstep.com>
bogdandrutu
approved these changes
Dec 15, 2023
codeboten
changed the title
Signed-off-by: Alex Boten <aboten@lightstep.com>
mx-psi
approved these changes
Dec 18, 2023
bogdandrutu
pushed a commit
that referenced
this pull request
Dec 18, 2023
Follows #29927, uses the new method Signed-off-by: Alex Boten <aboten@lightstep.com>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…-telemetry#29927) This PR adds methods to `generated_status` that returns a Meter/Tracer w/ the scopeName set for each component. I'm not set on where to put this method, added it to generated_status but could easily be in a generated_telemetry.go file as well. Follows open-telemetry#29926 Fixes open-telemetry#29921 --------- Signed-off-by: Alex Boten <aboten@lightstep.com>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
Follows open-telemetry#29927, uses the new method Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds methods to
generated_statusthat returns a Meter/Tracer w/ the scopeName set for each component. I'm not set on where to put this method, added it to generated_status but could easily be in a generated_telemetry.go file as well.Follows #29926
Fixes #29921