[exporter/clickhouse] Enhacement - TTL Fine-grained configuration control #29095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leartbeqiraj1
changed the title
|
Also, PTAL at the linter failures |
dmitryax
approved these changes
Nov 15, 2023
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…trol (open-telemetry#29095) **Description:** Added support for more control over TTL configuration. Currently, it supports timelines only in days, and now also in hours, minutes and seconds. **Link to tracking Issue:** [28675](open-telemetry#28675)
tarokkk
added a commit
to axoflow/opentelemetry-collector-contrib
that referenced
this pull request
Nov 29, 2023
codeboten
pushed a commit
that referenced
this pull request
Dec 8, 2023
Fixing regression error in #29095 The name of the `timeField` in `generateTTLExpr` was ignored and defaulted to `Timestamp`. The problem is that different tables have different names for this field. Now it is specified at each table creation. --------- Co-authored-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added support for more control over TTL configuration. Currently, it supports timelines only in days, and now also in hours, minutes and seconds.
Link to tracking Issue: 28675
Testing: Minimal test updates, only property name and type changes.
Documentation: Updated Readme accordingly.