Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][pkg/translator/azure] Add missing code owner @cparkins #28651

Merged
merged 2 commits into from
Nov 16, 2023
Merged

[chore][pkg/translator/azure] Add missing code owner @cparkins #28651

merged 2 commits into from
Nov 16, 2023
+1 −1

Conversation

crobert-1
Copy link
Member

@crobert-1 crobert-1 commented Oct 26, 2023 •
edited
Loading

Description:

This fixes inconsistency introduced with the creation of this package. In #25096 @cparkins was added as a code owner in the metadata.yaml but not the top level CODEOWNERS file.

@crobert-1 crobert-1 marked this pull request as ready for review October 26, 2023 23:04
@crobert-1 crobert-1 requested review from a team and mx-psi October 26, 2023 23:04
@github-actions github-actions bot requested a review from atoulme October 26, 2023 23:04
codeboten
codeboten approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, is the PR in the description correct? It looks like metadata was only modified in #25096

@cparkins
Copy link
Contributor

Oops! I saw this and didn't change it.

@crobert-1
Copy link
Member Author

Change looks good, is the PR in the description correct? It looks like metadata was only modified in #25096

Corrected it to #25096, thanks for catching!

@atoulme
Copy link
Contributor

atoulme commented Oct 26, 2023

Might need to add him to cmd/githubgen/allowlist.txt as well since he's not a member yet.

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 10, 2023
@atoulme atoulme added ready to merge Code review completed; ready to merge by maintainers and removed Stale labels Nov 10, 2023
@github-actions github-actions bot mentioned this pull request Nov 14, 2023
Closed
@TylerHelmuth
Copy link
Member

@cparkins can you approve the PR if you agree with being added as a code owner?

@TylerHelmuth TylerHelmuth removed the ready to merge Code review completed; ready to merge by maintainers label Nov 16, 2023
@cparkins
Copy link
Contributor

@TylerHelmuth - Done! Wasn't even aware I could approve or how to do it 👍

@TylerHelmuth TylerHelmuth merged commit c8eef68 into open-telemetry:main Nov 16, 2023
95 of 96 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 16, 2023
graphaelli pushed a commit to graphaelli/opentelemetry-collector-contrib that referenced this pull request Nov 17, 2023
@crobert-1 @graphaelli
[chore][pkg/translator/azure] Add missing code owner @cparkins (open-…
6440f03 
…telemetry#28651)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This fixes inconsistency introduced with the creation of this package.
In open-telemetry#25096 @cparkins was added as a code owner in the
[metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml)
but not the top level `CODEOWNERS` file.

Co-authored-by: Alex Boten <aboten@lightstep.com>
aishyandapalli pushed a commit to aishyandapalli/opentelemetry-collector-contrib that referenced this pull request Nov 17, 2023
@crobert-1 @aishyandapalli
[chore][pkg/translator/azure] Add missing code owner @cparkins (open-…
e75ca27 
…telemetry#28651)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This fixes inconsistency introduced with the creation of this package.
In open-telemetry#25096 @cparkins was added as a code owner in the
[metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml)
but not the top level `CODEOWNERS` file.

Co-authored-by: Alex Boten <aboten@lightstep.com>
jinja2 pushed a commit to jinja2/opentelemetry-collector-contrib that referenced this pull request Dec 18, 2023
@crobert-1 @jinja2
[chore][pkg/translator/azure] Add missing code owner @cparkins (open-…
311d823 
…telemetry#28651)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This fixes inconsistency introduced with the creation of this package.
In open-telemetry#25096 @cparkins was added as a code owner in the
[metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml)
but not the top level `CODEOWNERS` file.

Co-authored-by: Alex Boten <aboten@lightstep.com>
jinja2 pushed a commit to jinja2/opentelemetry-collector-contrib that referenced this pull request Dec 18, 2023
@crobert-1 @jinja2
[chore][pkg/translator/azure] Add missing code owner @cparkins (open-…
5e4671a 
…telemetry#28651)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This fixes inconsistency introduced with the creation of this package.
In open-telemetry#25096 @cparkins was added as a code owner in the
[metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml)
but not the top level `CODEOWNERS` file.

Co-authored-by: Alex Boten <aboten@lightstep.com>
jinja2 pushed a commit to jinja2/opentelemetry-collector-contrib that referenced this pull request Jan 16, 2024
@crobert-1 @jinja2
[chore][pkg/translator/azure] Add missing code owner @cparkins (open-…
b83c42e 
…telemetry#28651)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This fixes inconsistency introduced with the creation of this package.
In open-telemetry#25096 @cparkins was added as a code owner in the
[metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml)
but not the top level `CODEOWNERS` file.

Co-authored-by: Alex Boten <aboten@lightstep.com>
jinja2 pushed a commit to jinja2/opentelemetry-collector-contrib that referenced this pull request Jan 16, 2024
@crobert-1 @jinja2
[chore][pkg/translator/azure] Add missing code owner @cparkins (open-…
76f42de 
…telemetry#28651)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This fixes inconsistency introduced with the creation of this package.
In open-telemetry#25096 @cparkins was added as a code owner in the
[metadata.yaml](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/azure/metadata.yaml)
but not the top level `CODEOWNERS` file.

Co-authored-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@cparkins cparkins cparkins approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@mx-psi mx-psi Awaiting requested review from mx-psi

@atoulme atoulme Awaiting requested review from atoulme

Assignees

@dmitryax dmitryax

Labels
pkg/translator/azure
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@crobert-1 @cparkins @atoulme @TylerHelmuth @codeboten @dmitryax