[exporter/datasetexporter]: Make export of resources and scopes more flexible #27683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is built on top of #27663 since that PR is fixing NPE and this PR is using the helper function as well it tests. |
|
Majority of the changed lines are in the tests since I have introduced few configuration options and I have to test various combinations. |
peteryork
suggested changes
Oct 17, 2023
atoulme
approved these changes
Oct 17, 2023
mx-psi
reviewed
Oct 18, 2023
**Description:** This adds Grafana Agent as a distribution to some new components after the Grafana Agent v0.37 release. https://github.com/grafana/agent/blob/main/CHANGELOG.md#v0370-2023-10-10 **Link to tracking Issue:** None filed. **Testing:** None added. **Documentation:** Adding links to grafana agent in the alphabetically-sorted list. --------- Signed-off-by: Paschalis Tsilias <paschalis.tsilias@gmail.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
…open-telemetry#27824) As the next step, I'll update it to send readonly data to immutable exporters
…pen-telemetry#27825) This should help to catch exporters that are incorrectly claimed as not mutating.
…sts (open-telemetry#27848) The lifecycle test passes readonly data to processors claimed as not mutable to catch invalid behavior. Similar to open-telemetry#27825, but for processors tests.
…y#27869) The website docs.signalfx.com has been decommissioned and no longer resolves. Changing all doc links to the new doc website or removing them.
martin-majlis-s1
requested review from
djaglowski,
dmitryax,
TylerHelmuth,
bogdandrutu,
evan-bradley,
jpkrohling,
fatsheep9146,
Aneurysm9 and
andrzej-stencel
as code owners
|
I have added more tests to cover also the configuration options for traces. |
|
I have messed up the merge so it added whole world as reviewers. 🙈 |
mx-psi
removed request for
jpkrohling,
Aneurysm9,
bogdandrutu,
djaglowski,
dmitryax,
evan-bradley,
fatsheep9146,
TylerHelmuth and
andrzej-stencel
mx-psi
approved these changes
Oct 20, 2023
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…flexible (open-telemetry#27683) **Description:** Make export of resources and scopes more flexible **Link to tracking Issue:** open-telemetry#27651 , open-telemetry#27649 **Testing:** Unit tests **Documentation:** <Describe the documentation added.> **Note:**: This PR is on top of this PR - https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/27663/files - since it's introducing some helper functions and it's fixing NPE. Fixes open-telemetry#27651 Fixes open-telemetry#27649 --------- Signed-off-by: Paschalis Tsilias <paschalis.tsilias@gmail.com> Signed-off-by: Christian Kruse <ctkruse99@gmail.com> Co-authored-by: Paschalis Tsilias <tpaschalis@users.noreply.github.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> Co-authored-by: Andrzej Stencel <astencel@sumologic.com> Co-authored-by: hovavza <147598197+hovavza@users.noreply.github.com> Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com> Co-authored-by: Brandon Johnson <brandon.johnson@bluemedora.com> Co-authored-by: Miel Donkers <miel.donkers@gmail.com> Co-authored-by: bryan-aguilar <46550959+bryan-aguilar@users.noreply.github.com> Co-authored-by: sakulali <sakulali@126.com> Co-authored-by: Christian Kruse <ctkruse99@gmail.com> Co-authored-by: gord02 <53834349+gord02@users.noreply.github.com> Co-authored-by: bagmeg <joonsoo181005@gmail.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> Co-authored-by: OpenTelemetry Bot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Curtis Robert <crobert@splunk.com> Co-authored-by: VihasMakwana <121151420+VihasMakwana@users.noreply.github.com> Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…flexible (open-telemetry#27683) **Description:** Make export of resources and scopes more flexible **Link to tracking Issue:** open-telemetry#27651 , open-telemetry#27649 **Testing:** Unit tests **Documentation:** <Describe the documentation added.> **Note:**: This PR is on top of this PR - https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/27663/files - since it's introducing some helper functions and it's fixing NPE. Fixes open-telemetry#27651 Fixes open-telemetry#27649 --------- Signed-off-by: Paschalis Tsilias <paschalis.tsilias@gmail.com> Signed-off-by: Christian Kruse <ctkruse99@gmail.com> Co-authored-by: Paschalis Tsilias <tpaschalis@users.noreply.github.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> Co-authored-by: Andrzej Stencel <astencel@sumologic.com> Co-authored-by: hovavza <147598197+hovavza@users.noreply.github.com> Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com> Co-authored-by: Brandon Johnson <brandon.johnson@bluemedora.com> Co-authored-by: Miel Donkers <miel.donkers@gmail.com> Co-authored-by: bryan-aguilar <46550959+bryan-aguilar@users.noreply.github.com> Co-authored-by: sakulali <sakulali@126.com> Co-authored-by: Christian Kruse <ctkruse99@gmail.com> Co-authored-by: gord02 <53834349+gord02@users.noreply.github.com> Co-authored-by: bagmeg <joonsoo181005@gmail.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> Co-authored-by: OpenTelemetry Bot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Curtis Robert <crobert@splunk.com> Co-authored-by: VihasMakwana <121151420+VihasMakwana@users.noreply.github.com> Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Make export of resources and scopes more flexible
Link to tracking Issue: #27651 , #27649
Testing: Unit tests
Documentation:
Note:: This PR is on top of this PR - https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/27663/files - since it's introducing some helper functions and it's fixing NPE.
Fixes #27651
Fixes #27649