[chore] fix plogtest/CompareLogRecords input arg order #27575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test is unrelated, skipped it to unblock the CI in #27579 |
dmitryax
approved these changes
Oct 10, 2023
dmitryax
added
the
ready to merge
|
@jinja2 please rebase |
fatsheep9146
approved these changes
Oct 10, 2023
6 tasks
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…pen-telemetry#27575) Pass the correct `expected, actual` variables to CompareLogRecord fn in plogtest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Pass the correct
expected, actualvariables to CompareLogRecord fn in plogtest.Testing:
update unit tests