[cmd/opampsupervisor] Add integration/E2E tests #27002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
added
the
Skip Changelog
evan-bradley
force-pushed
the
supervisor-e2e-tests
branch
2 times, most recently
from
c0e0537
to
8190ff2
Compare
|
@evan-bradley ping me when this is ready for review. |
evan-bradley
force-pushed
the
supervisor-e2e-tests
branch
from
773fea1
to
2b6afc7
Compare
|
@tigrannajaryan The tests are passing in CI now, this is ready for review. Please take a look. |
srikanthccv
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Thanks for adding these @evan-bradley, it is great to have e2e tests for the supervisor.
I left some comments/questions to help me understand how the tests work.
evan-bradley
force-pushed
the
supervisor-e2e-tests
branch
from
6fa78c3
to
8475a4a
Compare
tigrannajaryan
approved these changes
Oct 11, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
evan-bradley
force-pushed
the
supervisor-e2e-tests
branch
from
8f2a2ee
to
f14a4a6
Compare
|
@atoulme Could you please take a look? |
atoulme
reviewed
Dec 5, 2023
atoulme
approved these changes
Dec 5, 2023
evan-bradley
force-pushed
the
supervisor-e2e-tests
branch
from
f52646b
to
3e7e1d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add tests that verify the Supervisor's behavior using a real Collector binary against an OpAMP server written with the opamp-go library. This tests a basic set of functionality mostly based on what is currently listed as implemented in the Supervisor's feature table.
Right now these tests start the Supervisor using the Go API to avoid process handling, but could be changed to start it through a binary in the future. I've placed these tests in the E2E testing workflow even though they run fairly quickly since they depend on a built Collector binary, may become more expansive in the future, and don't fit in any of the existing jobs in the
build-and-testworkflow. I'm open to placing them in another location if we'd prefer them elsewhere.This also updates opamp-go to v0.9.0 to take advantage of open-telemetry/opamp-go#200.
Link to tracking Issue:
Resolves #24292