Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using consumererror in no Consumer code #2657

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team March 11, 2021 20:29
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #2657 (1d728c9) into main (0358399) will increase coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2657   +/-   ##
=======================================
  Coverage   91.40%   91.41%           
=======================================
  Files         435      435           
  Lines       21608    21607    -1     
=======================================
+ Hits        19750    19751    +1     
+ Misses       1391     1390    -1     
+ Partials      467      466    -1     
Flag Coverage Δ
integration 69.18% <0.00%> (+0.04%) ⬆️
unit 90.32% <20.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/otelcontribcol/components.go 87.34% <20.00%> (-0.16%) ⬇️
receiver/k8sclusterreceiver/watcher.go 97.64% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0358399...1d728c9. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 55d2be2 into open-telemetry:main Mar 11, 2021
kisieland pushed a commit to kisieland/opentelemetry-collector-contrib that referenced this pull request Mar 16, 2021
since obsreport is the package name.

Fixes open-telemetry#2639

Signed-off-by: naseemkullah <naseem@transit.app>
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants