[receiver/redis] Command latency metrics. #26569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Sep 13, 2023
dmitryax
approved these changes
Sep 13, 2023
dmitryax
reviewed
Sep 13, 2023
| redis.cmd.latency: | ||
| enabled: false | ||
| description: Command execution latency | ||
| unit: us |
There was a problem hiding this comment.
Sorry, I missed this during the review. The OTel spec recommends sticking to basic units, e.g. seconds instead of milliseconds if possible https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/metrics.md#instrument-units. E.g. HTTP latency metrics is in seconds as well https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-metrics.md#metric-httpserverrequestduration
I think we should convert the values to seconds in a follow-up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added command latency metric to the redis receiver.
Link to tracking Issue: #6942
Testing: Added tests for parsing
latencystatssection of redis info.Documentation: Metric documentation in metadata.yaml