Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receiver/k8scluster: Use OTel conventions for metadata #2530

Merged

Conversation

asuresh4
Copy link
Member

@asuresh4 asuresh4 commented Mar 2, 2021

Description: Updates to metadata.

  • Update collected metadata to use OTel conventions
  • Replaces kubernetes_service_ prefix on service name in Pod metadata with k8s.service.

Testing: Updated tests.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #2530 (9f79731) into main (d3f3d9b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2530      +/-   ##
==========================================
+ Coverage   91.05%   91.06%   +0.01%     
==========================================
  Files         417      417              
  Lines       20935    20937       +2     
==========================================
+ Hits        19063    19067       +4     
+ Misses       1408     1407       -1     
+ Partials      464      463       -1     
Flag Coverage Δ
integration 69.22% <ø> (ø)
unit 89.94% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/k8sclusterreceiver/collection/metadata.go 100.00% <100.00%> (ø)
receiver/k8sclusterreceiver/collection/pods.go 94.11% <100.00%> (ø)
receiver/k8sclusterreceiver/watcher.go 97.64% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f3d9b...9f79731. Read the comment docs.

@jrcamp jrcamp assigned jrcamp and unassigned owais Mar 3, 2021
@asuresh4 asuresh4 force-pushed the k8sclusterreceiver-conventions branch from 290f508 to 9f79731 Compare March 3, 2021 18:38
@bogdandrutu bogdandrutu merged commit c0a618d into open-telemetry:main Mar 3, 2021
This was referenced Mar 15, 2021
kisieland referenced this pull request in kisieland/opentelemetry-collector-contrib Mar 16, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants