[receiver/splunkenterprise] Add scraping of two initial metrics #24800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalper2
force-pushed
the
splunkent-client
branch
7 times, most recently
from
ed3b209 to
9a15947
Compare
shalper2
force-pushed
the
splunkent-client
branch
from
9a15947 to
dca4400
Compare
atoulme
reviewed
Aug 10, 2023
atoulme
reviewed
Aug 10, 2023
| func newSplunkEntClient(cfg *Config) splunkEntClient { | ||
| // tls party | ||
| tr := &http.Transport{ | ||
| TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, |
There was a problem hiding this comment.
can we get this from the config instead? Does it have to be insecure always? Not a blocker but needs a follow up issue
There was a problem hiding this comment.
I agree with @atoulme , lets us the confighttp package to save needed to reimplement existing auth.
atoulme
reviewed
Aug 10, 2023
| // auth header every time we make a new request | ||
| authString := fmt.Sprintf("%s:%s", cfg.Username, cfg.Password) | ||
| auth64 := base64.StdEncoding.EncodeToString([]byte(authString)) | ||
| basicAuth := fmt.Sprintf("Basic %s", auth64) |
There was a problem hiding this comment.
you could maybe do this via basicauth extension. A follow up also
atoulme
reviewed
Aug 10, 2023
atoulme
reviewed
Aug 10, 2023
atoulme
reviewed
Aug 10, 2023
atoulme
reviewed
Aug 10, 2023
atoulme
reviewed
Aug 10, 2023
atoulme
reviewed
Aug 10, 2023
atoulme
reviewed
Aug 10, 2023
atoulme
reviewed
Aug 10, 2023
atoulme
reviewed
Aug 10, 2023
atoulme
reviewed
Aug 10, 2023
atoulme
reviewed
Aug 10, 2023
receiver/splunkenterprisereceiver/testdata/scraper/expected.yaml
Outdated
Show resolved
Hide resolved
atoulme
reviewed
Aug 10, 2023
shalper2
force-pushed
the
splunkent-client
branch
3 times, most recently
from
33d3f7f to
a45c8aa
Compare
dmitryax
approved these changes
Sep 12, 2023
shalper2
force-pushed
the
splunkent-client
branch
from
3abd80f to
7ce462f
Compare
dmitryax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: First pass at implementing the component. This PR is primarily focused on implementing the components architecture with less focus on the collection of actual Splunk performance data. This was done to keep the PR relatively short. Considerable work has however been done to implement the receiver logic and accompanying tests.
Link to tracking Issue: 12667
Testing: Unit testing on each internal component
Documentation: README.md