Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter/signalfx: Trim disk and network translation rules #2457

Merged

Conversation

asuresh4
Copy link
Member

Description: Remove certain disk/network translations.

Testing: Updated tests.

@asuresh4 asuresh4 requested a review from a team February 24, 2021 18:40
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #2457 (a4ba8fa) into main (768426b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2457      +/-   ##
==========================================
- Coverage   90.93%   90.91%   -0.02%     
==========================================
  Files         411      411              
  Lines       20467    20467              
==========================================
- Hits        18611    18608       -3     
- Misses       1395     1397       +2     
- Partials      461      462       +1     
Flag Coverage Δ
integration 69.22% <ø> (ø)
unit 89.76% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/k8sclusterreceiver/watcher.go 95.29% <0.00%> (-2.36%) ⬇️
processor/groupbytraceprocessor/event.go 95.96% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768426b...a4ba8fa. Read the comment docs.

@bogdandrutu bogdandrutu merged commit cf5abee into open-telemetry:main Feb 24, 2021
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants