Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporters/signalfx] breaking change: do not convert periods to underscores in dimension keys #2456

Merged
merged 1 commit into from
Feb 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Unreleased
- `signalfx` exporter: **breaking change** - Allow periods to be sent in dimension keys (#2456). Existing users who do not want to change this functionality can set `nonalphanumeric_dimension_chars` to `_-`

## v0.20.0

Expand Down
2 changes: 1 addition & 1 deletion exporter/signalfxexporter/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ The following configuration options can also be configured:
processor is enabled in the pipeline with one of the cloud provider detectors
or environment variable detector setting a unique value to `host.name` attribute
within your k8s cluster. And keep `override=true` in resourcedetection config.
- `nonalphanumeric_dimension_chars`: (default = `"_-"`) A string of characters
- `nonalphanumeric_dimension_chars`: (default = `"_-."`) A string of characters
that are allowed to be used as a dimension key in addition to alphanumeric
characters. Each nonalphanumeric dimension key character that isn't in this string
will be replaced with a `_`.
Expand Down
2 changes: 1 addition & 1 deletion exporter/signalfxexporter/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ func TestLoadConfig(t *testing.T) {
"host.name": "host",
},
},
NonAlphanumericDimensionChars: "_-",
NonAlphanumericDimensionChars: "_-.",
}
assert.Equal(t, &expectedCfg, e1)

Expand Down
2 changes: 1 addition & 1 deletion exporter/signalfxexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func createDefaultConfig() configmodels.Exporter {
},
DeltaTranslationTTL: 3600,
Correlation: correlation.DefaultConfig(),
NonAlphanumericDimensionChars: "_-",
NonAlphanumericDimensionChars: "_-.",
}
}

Expand Down