Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/snowflake] Change the type of Config.Password to be configopaque.String #24065

Merged
merged 3 commits into from
Jul 18, 2023
Merged

[receiver/snowflake] Change the type of Config.Password to be configopaque.String #24065

merged 3 commits into from
Jul 18, 2023

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Jul 10, 2023

Description:
Split out from: #17353

Link to tracking Issue: #17273

@mackjmr
[receiver/snowflake] Change the type of Config.Password to be `conf…
c36d46b 
…igopaque.String`

**Description:**
Split out from: open-telemetry#17353

**Link to tracking Issue:** open-telemetry#17273
@mackjmr mackjmr requested a review from a team July 10, 2023 14:03
@mackjmr mackjmr requested a review from dmitryax as a code owner July 10, 2023 14:03
@github-actions github-actions bot added the receiver/snowflake Snowflake receiver label Jul 10, 2023
@github-actions github-actions bot requested a review from shalper2 July 10, 2023 14:04
@crobert-1 crobert-1 mentioned this pull request Jul 11, 2023
Closed
crobert-1
crobert-1 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing CI test appears to be unrelated, I've filed issue #24223 to address it.

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jul 12, 2023
shalper2
shalper2 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@shalper2 shalper2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@codeboten codeboten merged commit 4232e5e into open-telemetry:main Jul 18, 2023
88 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@songy23 songy23 songy23 approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@shalper2 shalper2 shalper2 approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees

@bogdandrutu bogdandrutu

Labels
ready to merge Code review completed; ready to merge by maintainers receiver/snowflake Snowflake receiver
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mackjmr @codeboten @songy23 @crobert-1 @shalper2 @bogdandrutu