redisreceiver: Add missing units in metadata.yaml #23573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metric unit is required, see: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/mdatagen/metadata-schema.yaml#L72-L73. This PR adds the unit to metrics where this is missing: - redis.role - redis.cmd.calls - redis.clients.connected - redis.clients.blocked - redis.keys.expired - redis.keys.evicted - redis.connections.received - redis.connections.rejected - redis.memory.fragmentation_ratio - redis.rdb.changes_since_last_save - redis.commands.processed - redis.keyspace.hits - redis.keyspace.misses - redis.slaves.connected - redis.db.keys - redis.db.expires
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Could someone please remove the |
dmitryax
approved these changes
Jul 18, 2023
mackjmr
added a commit
to mackjmr/opentelemetry-collector-contrib
that referenced
this pull request
Jul 19, 2023
Now that open-telemetry#23573 has been merged, we can remove the todo.
dmitryax
pushed a commit
that referenced
this pull request
Jul 20, 2023
**Description:** Now that #23573 has been merged, we can remove the todo. Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Metric unit is required, see: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/mdatagen/metadata-schema.yaml#L72-L73.
This PR adds the unit to metrics where this is missing: