Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing unit in metadata.yaml #23449

Closed
wants to merge 12 commits into from
Closed

Add missing unit in metadata.yaml #23449

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
097a7d6
Add missing unit in metadata.yaml
mackjmr Jun 19, 2023
2e09f91
Update receiver/redisreceiver/metadata.yaml
mackjmr Jun 19, 2023
2ff3137
Update receiver/redisreceiver/metadata.yaml
mackjmr Jun 19, 2023
2687cf8
Update receiver/redisreceiver/metadata.yaml
mackjmr Jun 19, 2023
dc5836a
Update receiver/redisreceiver/metadata.yaml
mackjmr Jun 19, 2023
d1f6034
Remove By and run make generate
mackjmr Jun 19, 2023
1415848
remove ratio
mackjmr Jun 19, 2023
85bd0af
run golden.WriteMetrics
mackjmr Jun 19, 2023
2c1d741
add default unit 1
mackjmr Jun 19, 2023
f4249b8
golden.ReadMetrics for all tests
mackjmr Jun 19, 2023
fca3687
remove calls to golden.WriteMetrics
mackjmr Jun 19, 2023
4e9e9d9
run golden.WriteMetrics for all 3 receivers
mackjmr Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion receiver/aerospikereceiver/documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ Number of queries which ran more than query untracked_time (default 1 sec), Aero

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | true |
| {queries} | Sum | Int | Cumulative | true |

## Resource Attributes

Expand Down
2 changes: 1 addition & 1 deletion receiver/aerospikereceiver/internal/metadata/generated_metrics.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion receiver/aerospikereceiver/internal/metadata/generated_metrics_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions receiver/aerospikereceiver/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ metrics:
enabled: true
description: Number of queries tracked by the system.
extended_documentation: Number of queries which ran more than query untracked_time (default 1 sec), Aerospike metric query_tracked
unit: '{queries}'
sum:
value_type: int
input_type: string
Expand Down
4 changes: 2 additions & 2 deletions receiver/postgresqlreceiver/documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Number of times the background writer stopped a cleaning scan because it had wri

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | true |
| {stoppages} | Sum | Int | Cumulative | true |

### postgresql.blocks_read

Expand Down Expand Up @@ -226,7 +226,7 @@ Number of user tables in a database.

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | false |
| {tables} | Sum | Int | Cumulative | false |

### postgresql.table.size

Expand Down
4 changes: 2 additions & 2 deletions receiver/postgresqlreceiver/internal/metadata/generated_metrics.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions receiver/postgresqlreceiver/internal/metadata/generated_metrics_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions receiver/postgresqlreceiver/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ metrics:
aggregation: cumulative
monotonic: true
value_type: int
unit: "{stoppages}"
postgresql.blocks_read:
enabled: true
description: The number of blocks read.
Expand Down Expand Up @@ -235,6 +236,7 @@ metrics:
aggregation: cumulative
monotonic: false
value_type: int
unit: "{tables}"
postgresql.table.size:
attributes: []
description: Disk space used by a table.
Expand Down
40 changes: 20 additions & 20 deletions receiver/redisreceiver/documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,31 +18,31 @@ Number of clients pending on a blocking call

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | false |
| {clients} | Sum | Int | Cumulative | false |

### redis.clients.connected

Number of client connections (excluding connections from replicas)

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | false |
| {connections} | Sum | Int | Cumulative | false |

### redis.clients.max_input_buffer

Biggest input buffer among current client connections

| Unit | Metric Type | Value Type |
| ---- | ----------- | ---------- |
| | Gauge | Int |
| By | Gauge | Int |

### redis.clients.max_output_buffer

Longest output list among current client connections

| Unit | Metric Type | Value Type |
| ---- | ----------- | ---------- |
| | Gauge | Int |
| By | Gauge | Int |

### redis.commands

Expand All @@ -58,23 +58,23 @@ Total number of commands processed by the server

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | true |
| {commands} | Sum | Int | Cumulative | true |

### redis.connections.received

Total number of connections accepted by the server

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | true |
| {connections} | Sum | Int | Cumulative | true |

### redis.connections.rejected

Number of connections rejected because of maxclients limit

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | true |
| {connections} | Sum | Int | Cumulative | true |

### redis.cpu.time

Expand Down Expand Up @@ -110,7 +110,7 @@ Number of keyspace keys with an expiration

| Unit | Metric Type | Value Type |
| ---- | ----------- | ---------- |
| | Gauge | Int |
| {keys} | Gauge | Int |

#### Attributes

Expand All @@ -124,7 +124,7 @@ Number of keyspace keys

| Unit | Metric Type | Value Type |
| ---- | ----------- | ---------- |
| | Gauge | Int |
| {keys} | Gauge | Int |

#### Attributes

Expand All @@ -138,31 +138,31 @@ Number of evicted keys due to maxmemory limit

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | true |
| {keys} | Sum | Int | Cumulative | true |

### redis.keys.expired

Total number of key expiration events

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | true |
| {events} | Sum | Int | Cumulative | true |

### redis.keyspace.hits

Number of successful lookup of keys in the main dictionary

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | true |
| {lookups} | Sum | Int | Cumulative | true |

### redis.keyspace.misses

Number of failed lookup of keys in the main dictionary

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | true |
| {lookups} | Sum | Int | Cumulative | true |

### redis.latest_fork

Expand All @@ -178,7 +178,7 @@ Ratio between used_memory_rss and used_memory

| Unit | Metric Type | Value Type |
| ---- | ----------- | ---------- |
| | Gauge | Double |
| {ratio} | Gauge | Double |

### redis.memory.lua

Expand Down Expand Up @@ -234,31 +234,31 @@ Number of changes since the last dump

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | false |
| {changes} | Sum | Int | Cumulative | false |

### redis.replication.backlog_first_byte_offset

The master offset of the replication backlog buffer

| Unit | Metric Type | Value Type |
| ---- | ----------- | ---------- |
| | Gauge | Int |
| By | Gauge | Int |

### redis.replication.offset

The server's current replication offset

| Unit | Metric Type | Value Type |
| ---- | ----------- | ---------- |
| | Gauge | Int |
| By | Gauge | Int |

### redis.slaves.connected

Number of connected replicas

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | false |
| {connections} | Sum | Int | Cumulative | false |

### redis.uptime

Expand All @@ -284,7 +284,7 @@ Total number of calls for a command

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | true |
| {calls} | Sum | Int | Cumulative | true |

#### Attributes

Expand Down Expand Up @@ -320,7 +320,7 @@ Redis node's role

| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | false |
| {role} | Sum | Int | Cumulative | false |

#### Attributes

Expand Down
Loading