Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][receiver/zookeeper] Refactor to separate connection/request from metric processing #22752

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

djaglowski
Copy link
Member

Motivated by #22726, which can benefit from a cleaner separation of these concerns.

@djaglowski djaglowski marked this pull request as ready for review May 24, 2023 19:38
@djaglowski djaglowski requested review from a team and Aneurysm9 May 24, 2023 19:38
@djaglowski djaglowski requested a review from dmitryax June 1, 2023 14:03
@djaglowski
Copy link
Member Author

@open-telemetry/collector-contrib-approvers, PTAL

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise LGTM

receiver/zookeeperreceiver/scraper.go Show resolved Hide resolved
@djaglowski djaglowski merged commit 59def9a into open-telemetry:main Jun 5, 2023
@djaglowski djaglowski deleted the zookeeper-client branch June 5, 2023 17:21
@github-actions github-actions bot added this to the next release milestone Jun 5, 2023
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
…rom metric processing (open-telemetry#22752)

[chore][receiver/zookeeper] Refactor to separate connection/request logic from metric processing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants