-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/awscloudwatch] Fix issue with log stream filtering in the cloudwatch receiver #22715
Merged
djaglowski
merged 3 commits into
open-telemetry:main
from
rnishtala-sumo:rnishtala_cw_receiver
May 26, 2023
Merged
[receiver/awscloudwatch] Fix issue with log stream filtering in the cloudwatch receiver #22715
djaglowski
merged 3 commits into
open-telemetry:main
from
rnishtala-sumo:rnishtala_cw_receiver
May 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loudwatch receiver
rnishtala-sumo
force-pushed
the
rnishtala_cw_receiver
branch
from
May 25, 2023 16:03
b3f68f2
to
8370ec9
Compare
djaglowski
reviewed
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@schmikei, will you also take a look?
schmikei
approved these changes
May 25, 2023
rnishtala-sumo
force-pushed
the
rnishtala_cw_receiver
branch
from
May 25, 2023 18:30
32f953e
to
acf6b7a
Compare
djaglowski
reviewed
May 25, 2023
djaglowski
approved these changes
May 25, 2023
djaglowski
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
May 25, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix issue with log stream filtering in the cloudwatch receiver
Link to tracking Issue:
#22123
Testing:
Modified a unit test case that asserts on the number of requests being made for a single log stream prefix configured.