Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/awscloudwatch] Fix issue with log stream filtering in the cloudwatch receiver #22715

Merged
merged 3 commits into from
May 26, 2023

Conversation

rnishtala-sumo
Copy link
Contributor

@rnishtala-sumo rnishtala-sumo commented May 23, 2023

Description:
Fix issue with log stream filtering in the cloudwatch receiver

Link to tracking Issue:
#22123

Testing:
Modified a unit test case that asserts on the number of requests being made for a single log stream prefix configured.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 23, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rnishtala-sumo / name: Raj Nishtala (b3f68f2c556ba8bafb0d920e3d8ce4fe0f55e69f)

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@schmikei, will you also take a look?

.chloggen/rnishtala_cw_receiver.yaml Outdated Show resolved Hide resolved
.chloggen/rnishtala_cw_receiver.yaml Outdated Show resolved Hide resolved
@rnishtala-sumo rnishtala-sumo force-pushed the rnishtala_cw_receiver branch from 32f953e to acf6b7a Compare May 25, 2023 18:30
@rnishtala-sumo rnishtala-sumo requested a review from djaglowski May 25, 2023 18:45
@djaglowski djaglowski added the ready to merge Code review completed; ready to merge by maintainers label May 25, 2023
@djaglowski djaglowski merged commit 9b46694 into open-telemetry:main May 26, 2023
@github-actions github-actions bot added this to the next release milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/awscloudwatch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants