Honor enabled resource attributes #22105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
May 19, 2023
Comment on lines
+99
to
+101
| if rs.cfg.MetricsBuilderConfig.ResourceAttributes.RedisVersion.Enabled { | ||
| resourceMetricOptions = append(resourceMetricOptions, metadata.WithRedisVersion(rs.getRedisVersion(inf))) | ||
| } |
There was a problem hiding this comment.
I don't believe this is needed. Its a responsibility of the metrics builder and should be handled by WithRedisVersion. If it's not working for any reason, let's fix the metrics builder
atoulme
reviewed
May 19, 2023
| @@ -33,6 +33,8 @@ func TestRedisRunnable(t *testing.T) { | |||
| ilm := rm.ScopeMetrics().At(0) | |||
| il := ilm.Scope() | |||
| assert.Equal(t, "otelcol/redisreceiver", il.Name()) | |||
| // Only version should be enabled by default at this moment | |||
| assert.Equal(t, 1, rm.Resource().Attributes().Len()) | |||
There was a problem hiding this comment.
We can add this assertion to the test as a chore PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enables the resource_attribute flag in redis
Link to tracking Issue: Enables 22044
Testing: integration test in goland