[fileexporter] refactor to use compressed writer in fileexporter #22079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 18, 2023
jmacd
reviewed
May 19, 2023
jmacd
reviewed
May 19, 2023
|
This change probably needs to be documented. It's breaking in a sense, but since the file receiver has not supported the things this is breaking, I would argue it doesn't matter. |
jmacd
approved these changes
May 20, 2023
codeboten
reviewed
May 30, 2023
atoulme
reviewed
May 30, 2023
atoulme
reviewed
May 30, 2023
moh-osman3
force-pushed
the
mohosman/fileexporter-compressed-writer
branch
from
37d1aca to
f4b742f
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
moh-osman3
force-pushed
the
mohosman/fileexporter-compressed-writer
branch
from
9204fc5 to
9ccaac8
Compare
|
@atoulme @codeboten I refactored this change again and resolved a bug I found while testing. Would you mind reviewing again when you get the chance? Thanks! |
moh-osman3
force-pushed
the
mohosman/fileexporter-compressed-writer
branch
from
aee1536 to
fd1c85b
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
[PART 1] Breaking #22021 into 2 PRs
This PR is refactoring of the fileexporter to use a compressed writer. The goal of this change is to make it easier to read compressed data in the filereceiver by using a corresponding compressed reader.
This also makes it clearer to distinguish between the two types of writes. 1. writing line by line used for json and compressed json 2. writing a chunk at a time prefixed with the chunk size
For more context see part 2: #22080
Link to tracking Issue:
Related to #13626
Supports ongoing effort to record and replay telemetry data for experimental/research purposes
Testing:
Locally running otelcontribcol and writing to a file using all supported formats (json, json+compression, proto, proto+compression) and recovering original metrics using filereceiver
Documentation: