Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] Revise OTTL function nomenclature #22032

Merged

Conversation

evan-bradley
Copy link
Contributor

Description:

Renames functions mutating data to be called Editors, which distinguishes them more clearly from Converters. Previously, Editors were called both "invocations" and "functions", which made their usage a little unclear.

Documentation: I had to rearrange parts of the documentation to cover this change.

@evan-bradley evan-bradley added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 17, 2023
@evan-bradley evan-bradley requested a review from a team May 17, 2023 02:14
@github-actions github-actions bot requested a review from kentquirk May 17, 2023 02:14
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great stuff

@TylerHelmuth TylerHelmuth merged commit c8da52b into open-telemetry:main May 17, 2023
@github-actions github-actions bot added this to the next release milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/ottl Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants