[receiver/splunkhec] expose the Splunk HEC codec #21254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@MovieStoreGuy this one is for you ;) |
|
Can I leave you to resolve the conflicts @atoulme ? |
atoulme
force-pushed
the
move_hec_to_codec
branch
2 times, most recently
from
fd04cae to
fa14b9d
Compare
github-actions
bot
added
cmd/configschema
atoulme
force-pushed
the
move_hec_to_codec
branch
4 times, most recently
from
1ffd424 to
81711e2
Compare
mx-psi
approved these changes
May 15, 2023
|
Sounds like you need to add a replace somewhere: |
atoulme
force-pushed
the
move_hec_to_codec
branch
2 times, most recently
from
fc18be0 to
6abca82
Compare
MovieStoreGuy
approved these changes
May 21, 2023
pkg/codec/splunkhec/go.mod
Outdated
|
|
||
| require ( | ||
| github.com/json-iterator/go v1.1.12 | ||
| github.com/open-telemetry/opentelemetry-collector-contrib/internal/splunk v0.76.3 |
There was a problem hiding this comment.
set these to v0.77.0
atoulme
force-pushed
the
move_hec_to_codec
branch
from
5463b12 to
5cbbc66
Compare
|
Looks like |
|
@atoulme @MovieStoreGuy, why do we need this functionality exported in |
I don't believe anything outside of the project would consume it, the intention was to expose the functionality with the encoding extension they I've only just started. |
|
OK to wait for the extension. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Move out of the splunkhec receiver the codec that translates from Splunk HEC JSON to pdata.
Link to tracking Issue:
#21152
Testing:
Test coverage is unchanged on the receiver.
Documentation:
N/A