[receiver/purefa] Some endpoints from purefareceiver were having trouble to scraped. #21100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrroberts-pure
suggested changes
Apr 21, 2023
6 tasks
dgoscn
changed the title
|
Issue #21248 describes the issue this PR is addressing. |
jpkrohling
requested changes
May 3, 2023
|
Confirmed fix for Issue #21248 |
…he exporter to scrape
dgoscn
force-pushed
the
purestorage_flasharray_commom_labels_issue
branch
from
ad288f1
to
c6a7c54
Compare
…nd use the exporter to scrape" This reverts commit cb8d199.
… w/ lint correction
jpkrohling
approved these changes
May 31, 2023
Caleb-Hurshman
pushed a commit
to observIQ/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2023
…ble to scraped. (open-telemetry#21100) * [receiver/purefa] Some endpoints were not being scraped and this new code fixes * [receiver/purefa] Refactor a commom label present on endpoints * [receiver/purefa] re-adding the righ value with semantic conventions for the labels * [receiver/purefa] Mock a test http server to expose metrics and use the exporter to scrape * [receiver/purefa] Add the check to the return of the mock response * [receiver/purefa] Resolve conflict on test file * [correction/readme] Resolving conflict with lint errors * Revert "[receiver/purefa] Mock a test http server to expose metrics and use the exporter to scrape" This reverts commit cb8d199. * [receiver/purefa] Remove duplicated host label from volumes and hosts * [receiver/purefa] Remove duplicated host label from volumes and hosts w/ lint correction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some endpoints from Pure Flash Array Receiver were not being scraped: array, pods, and directories.
The reason for that could be caused by a missing pattern insertion on the volumes scraper endpoint. This snippet code comes to fix this.
Link to tracking Issue:
#14886
Testing:
The validation test must be made by the default configs on config.yaml that is present on README.md.
Documentation:
Present on README