-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/purefa] Some endpoints from purefareceiver were having trouble to scraped. #21100
[receiver/purefa] Some endpoints from purefareceiver were having trouble to scraped. #21100
Conversation
Issue #21248 describes the issue this PR is addressing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see tests for this change, asserting the final state of the metrics and their labels. It's then easier to see what exactly is going on.
Confirmed fix for Issue #21248 |
…he exporter to scrape
ad288f1
to
c6a7c54
Compare
…nd use the exporter to scrape" This reverts commit cb8d199.
… w/ lint correction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving, as PureStorage folks have tested and confirmed this to work. The new functional test is coming on a follow-up PR.
…ble to scraped. (open-telemetry#21100) * [receiver/purefa] Some endpoints were not being scraped and this new code fixes * [receiver/purefa] Refactor a commom label present on endpoints * [receiver/purefa] re-adding the righ value with semantic conventions for the labels * [receiver/purefa] Mock a test http server to expose metrics and use the exporter to scrape * [receiver/purefa] Add the check to the return of the mock response * [receiver/purefa] Resolve conflict on test file * [correction/readme] Resolving conflict with lint errors * Revert "[receiver/purefa] Mock a test http server to expose metrics and use the exporter to scrape" This reverts commit cb8d199. * [receiver/purefa] Remove duplicated host label from volumes and hosts * [receiver/purefa] Remove duplicated host label from volumes and hosts w/ lint correction
Description:
Some endpoints from Pure Flash Array Receiver were not being scraped: array, pods, and directories.
The reason for that could be caused by a missing pattern insertion on the volumes scraper endpoint. This snippet code comes to fix this.
Link to tracking Issue:
#14886
Testing:
The validation test must be made by the default configs on config.yaml that is present on README.md.
Documentation:
Present on README