Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translator/loki] loki exporter add raw log export format #19164

Conversation

jmichalek132
Copy link
Contributor

@jmichalek132 jmichalek132 commented Mar 1, 2023

Description:

As discussed in slack, right now when using the loki exporter, to access the raw log message we need to run a query like this:

{exporter=OTLP} | json | line_format `{{.body}}`

To avoid having to parse the log messages twice, I propose introducing raw format. Instead of sending the whole log record (including attributes and resources attributes) as a json, just send the body containing the actual log message.

Link to tracking Issue:

Related to #18742

Testing:
Tested in our testing environment with locally built image.

Screenshot 2023-02-28 at 18 49 15

Documentation:

@runforesight
Copy link

runforesight bot commented Mar 1, 2023

Foresight Summary

    
Major Impacts

TestElasticsearchIntegration ❌ failed 1 times in 6 runs (16% fail rate).
TestElasticsearchIntegration/Running_elasticsearch_7.16.3 ❌ failed 1 times in 6 runs (16% fail rate).
build-and-test-windows duration(12 seconds) has decreased 40 minutes 15 seconds compared to main branch avg(40 minutes 27 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 12 seconds (40 minutes 18 seconds less than main branch avg.) and finished at 16th Mar, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 1 minute 34 seconds and finished at 16th Mar, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 52 seconds (⚠️ 38 seconds more than main branch avg.) and finished at 16th Mar, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 43 seconds and finished at 16th Mar, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 27 seconds (3 minutes 55 seconds less than main branch avg.) and finished at 16th Mar, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  e2e-tests workflow has finished in 11 minutes 12 seconds (3 minutes 54 seconds less than main branch avg.) and finished at 16th Mar, 2023.


Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

✅  load-tests workflow has finished in 15 minutes 8 seconds (⚠️ 2 minutes 38 seconds more than main branch avg.) and finished at 16th Mar, 2023.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 18  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  build-and-test workflow has finished in 33 minutes 38 seconds (21 minutes 23 seconds less than main branch avg.) and finished at 17th Mar, 2023.


Job Failed Steps Tests
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@jmichalek132 jmichalek132 marked this pull request as ready for review March 1, 2023 14:46
@jmichalek132 jmichalek132 requested a review from a team March 1, 2023 14:46
@jpkrohling
Copy link
Member

@mar4uk, could you please review this one?

Copy link
Contributor

@mar4uk mar4uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add tests to cover conversion to the new format?

pkg/translator/loki/convert.go Outdated Show resolved Hide resolved
@jmichalek132
Copy link
Contributor Author

could you please add tests to cover conversion to the new format?

Added test, is this good enough?

@jmichalek132 jmichalek132 requested a review from mar4uk March 8, 2023 10:29
@jmichalek132 jmichalek132 force-pushed the jm-loki-exporter-add-raw-log-message-option branch from 960d756 to ff40837 Compare March 8, 2023 11:15
@mar4uk
Copy link
Contributor

mar4uk commented Mar 8, 2023

LGTM 👍
Some checks have failed. Please run make gofmt all as recommended here

@jmichalek132
Copy link
Contributor Author

Thank you @mar4uk for the review, is there anything else I need to do to get this merged :) ?

@kovrus
Copy link
Member

kovrus commented Mar 13, 2023

Can you please document it in loki exporter?

@jmichalek132
Copy link
Contributor Author

Can you please document it in loki exporter?

Would this be updating the readme for the exporter?
Currently, there is no mention of the different formats there.

@kovrus
Copy link
Member

kovrus commented Mar 15, 2023

Can you please document it in loki exporter?

Would this be updating the readme for the exporter? Currently, there is no mention of the different formats there.

We probably should document how to configure the format via the loki.format attribute hint.

@mar4uk
Copy link
Contributor

mar4uk commented Mar 15, 2023

let's add the format section first in the separate PR #19734

When it is merged, let's add information about format=raw here

@jmichalek132 jmichalek132 force-pushed the jm-loki-exporter-add-raw-log-message-option branch from 74ac08b to ef182f7 Compare March 16, 2023 17:37
@github-actions github-actions bot added the exporter/loki Loki Exporter label Mar 16, 2023
@codeboten codeboten merged commit 2417c3e into open-telemetry:main Mar 18, 2023
@jmichalek132 jmichalek132 deleted the jm-loki-exporter-add-raw-log-message-option branch March 21, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants